Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGR-36: Package update and cleanup #108

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Conversation

EdwinGuzman
Copy link
Member

@EdwinGuzman EdwinGuzman commented Jul 22, 2024

Node fixes for TGR-36. This adds on top of the existing PR #106 and resolves the 10 dependabot package issues.

Screenshot 2024-07-22 at 1 57 44 PM

Add

  • Adds the following npm packages:
    babel/preset-typescript, babel-jest

Update

  • Upgrade to Node 20.
  • Uses ts-jest over esbuild-jest.
  • Updates the Reservoir DS to 3.1.7 and removes unnecessary stylesheet.
  • Updates the following npm packages:
    @nypl/design-system-react-components, @parcel/transformer-sass, @testing-library/jest-dom, @testing-library/react, @types/jest, @types/js-cookie, @types/node, @types/react, @types/react-dom, @types/react-test-renderer, @typescript-eslint/eslint-plugin, @typescript-eslint/parser, esbuild, eslint, eslint-config-prettier, eslint-plugin-import, eslint-plugin-jsx-a11y, eslint-plugin-prettier, eslint-plugin-react, eslint-plugin-react-hooks, husky, jest, jest-config, jest-environment-jsdom, js-cookie, lint-staged, os-browserify, parcel, path-browserify, process, react, react-dom, react-error-boundary, react-test-renderer, ts-jest, ts-node

Remove

  • Removes the following npm packages:
    esbuild-jest

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
registry-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 7:38pm

@EdwinGuzman
Copy link
Member Author

Note: the vercel deployment works but there's a parcel caching issue. This is actually good because we should not deploy this to Vercel at the moment.

@EdwinGuzman EdwinGuzman requested a review from keithbauer July 22, 2024 19:43
@EdwinGuzman
Copy link
Member Author

@keithbauer as far as I know or can tell, this front-end is no longer used in https://github.com/NYPL-Simplified/library_registry/. It also looks like the deployment strategy has changed and the UI runs as a standalone app. What I don't know is what the status of library_registry is and how it's deployed. Would you happen to know?

@keithbauer
Copy link

keithbauer commented Jul 22, 2024

Those are some good questions. I haven't done much work with library_registry, but I believe it's still in use by NYPL alongside the Circulation Manager. From what I can tell the library_registry is deployed through bamboo though it has been a while since the last deploy. I believe this front-end is still in use and is in the registry's package.json, the Dockerfile copies it in and installs.

Edit: Though it is a bit confusing to see releases with 2.x without that being reflected in the registry's package.json. As well as the production deploy Github Action.

@EdwinGuzman
Copy link
Member Author

Right, the previous release is not pointed to in the library registry repo. At some point it seems like the backend and frontend were separated. We'll have to ask for more docs or clarification. It might make any updates easier on the backend if the reference can be removed entirely.

Copy link

@danamansana danamansana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, love the 0 vulnerabilities

@EdwinGuzman EdwinGuzman changed the title WIP TGR-36: Package update and cleanup TGR-36: Package update and cleanup Jul 26, 2024
@EdwinGuzman EdwinGuzman merged commit 3702299 into node-20-upgrade Jul 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants