-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TGR-36: Package update and cleanup #108
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Note: the vercel deployment works but there's a parcel caching issue. This is actually good because we should not deploy this to Vercel at the moment. |
@keithbauer as far as I know or can tell, this front-end is no longer used in https://github.com/NYPL-Simplified/library_registry/. It also looks like the deployment strategy has changed and the UI runs as a standalone app. What I don't know is what the status of |
Those are some good questions. I haven't done much work with Edit: Though it is a bit confusing to see releases with 2.x without that being reflected in the registry's package.json. As well as the production deploy Github Action. |
Right, the previous release is not pointed to in the library registry repo. At some point it seems like the backend and frontend were separated. We'll have to ask for more docs or clarification. It might make any updates easier on the backend if the reference can be removed entirely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, love the 0 vulnerabilities
Node fixes for TGR-36. This adds on top of the existing PR #106 and resolves the 10 dependabot package issues.
Add
npm
packages:babel/preset-typescript
,babel-jest
Update
ts-jest
overesbuild-jest
.3.1.7
and removes unnecessary stylesheet.npm
packages:@nypl/design-system-react-components
,@parcel/transformer-sass
,@testing-library/jest-dom
,@testing-library/react
,@types/jest
,@types/js-cookie
,@types/node
,@types/react
,@types/react-dom
,@types/react-test-renderer
,@typescript-eslint/eslint-plugin
,@typescript-eslint/parser
,esbuild
,eslint
,eslint-config-prettier
,eslint-plugin-import
,eslint-plugin-jsx-a11y
,eslint-plugin-prettier
,eslint-plugin-react
,eslint-plugin-react-hooks
,husky
,jest
,jest-config
,jest-environment-jsdom
,js-cookie
,lint-staged
,os-browserify
,parcel
,path-browserify
,process
,react
,react-dom
,react-error-boundary
,react-test-renderer
,ts-jest
,ts-node
Remove
npm
packages:esbuild-jest